fix: fix signature inspection on debounced/throttled, update typing and wrapped #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #228 will not alter performanceComparing Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1809 1829 +20
=========================================
+ Hits 1809 1829 +20
☔ View full report in Codecov by Sentry. |
andy-sweet
approved these changes
Aug 14, 2023
| @@ -27,9 +30,18 @@ def __init__( | |||
| self._args: tuple[Any, ...] = () | |||
| self._kwargs: dict[str, Any] = {} | |||
|
|
|||
| # this mimics what functools.wraps does, but avoids __dict__ usage and other | |||
| # things that won't work with mypyc... HOWEVER, most of these dynamic | |||
There was a problem hiding this comment.
By won't work, I guess you mean that mypyc will just ignore these? But won't error?
There was a problem hiding this comment.
correct. __doc__ will be None on mypyc... (i.e. it won't update the doc on the instance itself)
tlambert03
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in mypyc's words: "
inspect.signaturechokes on compiled functions"... which is a bummer for throttled/debounced if we're going to use them as callbacks (which is their main goal).This PR fixes napari/napari#6149 (comment) by telling inspect.signature how to get to the wrapped function. I think it should be good enough, but if more problems arise, we can just skip mypyc compilation on these modules.
cc @andy-sweet
edit: i just decided not to compile that module for now.