Code

Resolve 8 issues#89

Code

Open

johndoknjas wants to merge 37 commits intopy-stockfish:masterpy-stockfish/stockfish:masterfrom johndoknjas:ucinewgamejohndoknjas/stockfish-1:ucinewgameCopy head branch name to clipboard

+209-134

Commits

Commits on Aug 23, 2024

• Make the send_ucinewgame_token param False by default in set_fen_position.

  johndoknjas

  committed
  bcde8f3

• Make the send_ucinewgame_token param of _prepare_for_new_position not optional.

  johndoknjas

  committed
  80984c2

• Use is rather than == in tests with booleans to check that the value is not just truthy.

  johndoknjas

  committed
  016f443

• Change the name of set_position to make_moves_from_start.

  johndoknjas

  committed
  2037856

• The set_elo_rating test occasionally fails on my computer (on past commits too). So add a2a4.

  johndoknjas

  committed
  68b1079

Commits on Aug 24, 2024

• Do not send the ucinewgame token by default in make_moves_from_starting_position.

  johndoknjas

  committed
  ba7faa2

• Update README.md

  johndoknjas

  authored
  8a56c11

• Format with black.

  johndoknjas

  committed
  c682d6b

• Update test.

  johndoknjas

  committed
  96163d2

• Some minor pylint recommendations.

  johndoknjas

  committed
  5f83e13

• Update README.md

  johndoknjas

  authored
  b556506

• Trim some trailing whitespace.

  johndoknjas

  committed
  7aee8d0

• Merge branch 'master' into ucinewgame

  johndoknjas

  committed
  26eb58f

Commits on Aug 25, 2024

• Correctly do short-circuiting.

  johndoknjas

  committed
  559dcaa

Commits on Aug 26, 2024

• Do not have the option of sending the ucinewgame command from one of the set position functions. Rather, make a new function that can do this if the user wants.

  johndoknjas

  committed
  d2701b7

• Don't send the ucinewgame command in the constructor; if the hash table is only a couple GBs, this can take more than half a second.

  johndoknjas

  committed
  ab682b9

• Call self._is_ready() before sending a command. Also remove some unnecessary calls to self._is_ready().

  johndoknjas

  committed
  39822e1

• Add a docstring to _put.

  johndoknjas

  committed
  19ba2c4

• Remove the _is_ready function and put its code directly in the _put function (since it is only used there).

  johndoknjas

  committed
  4123b43

Commits on Aug 27, 2024

• Make _is_ready back into its own function.

  johndoknjas

  committed
  4f53176

• After sending the ucinewgame command, wait until Stockfish finishes doing it.

  johndoknjas

  committed
  8cc04be

• Add a couple other _is_ready() checks.

  johndoknjas

  committed
  07afd5c

• Make the max allowed hash size 2^25 MB if on a 64-bit system.

  johndoknjas

  committed
  351be02

• Update comment in test.

  johndoknjas

  committed
  05aacd4

• Replace assert usages in models.py, as assertions can be ignored by not running in debug mode.

  johndoknjas

  committed
  ca1e746

• Modify the description in the readme to match that in setup.py.

  johndoknjas

  committed
  0618203

• Undo a change from a few years ago in commit 1c7be8b, where the make_moves function was modified to set the fen position after each move (in order to check for the correctness of each move). The is…

  Show description for 25473eb
  johndoknjas

  committed
  25473eb

• Add a threefold detection test for the make_moves function.

  johndoknjas

  committed
  eaf6a0a

• Update gitignore.

  johndoknjas

  committed
  bbcfa8b

• Format with black.

  johndoknjas

  committed
  55c025a

• Expand the threefold test, and add an allowed value in another test.

  johndoknjas

  committed
  693cbd0

• Format with black.

  johndoknjas

  committed
  8f98dcd

• Fix test.

  johndoknjas

  committed
  9458184

• Fix mypy error.

  johndoknjas

  committed
  903e52e

• Write helper function to test for types and then compare.

  johndoknjas

  committed
  3854c90

• Use the new compare helper function in some other tests too.

  johndoknjas

  committed
  4e28a42

• Fix problem in test.

  johndoknjas

  committed
  4007b6c