-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the gitignore and readme to aid contributing #70
Conversation
…he `stockfish` directory. This allows developers to more easily test changes they make to `stockfish/models.py`.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
@kieferro I added one more update to the readme - just putting the new section on contributing right before testing, and then updating the testing section with a tip on how to run things locally with the right path name. This is how I run the tests on my machine, was just wondering if you do something similar. If so, this may be something we could look into changing, so that contributors can run the test suite without needing to modify the default path in |
Yes, I do pretty much the same.
Yes, I think that's a very good suggestion. Maybe we could use a setup with a command line argument, which is read by |
5ed61b6
to
43f0ebe
Compare
This PR adds some tips to the readme on how contributors can test their changes made to
stockfish/models.py
. The gitignore is also updated so that executables and amain.py
file are ignored in thestockfish
folder. Minor updates to someget_wdl_stats
stuff is also done.