Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1311 - <a> HTML tag applying styling rules to all following content #1316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

K-Hern
Copy link

@K-Hern K-Hern commented Dec 4, 2024

Fixed rendering of content following <a> tags; now correctly resets emphasis style post </a> tag: hyperlink styling contained within the tag authority. Updated documentation to reflect this change.

Also corrected minor typo in documentation.

Checklist:

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@K-Hern K-Hern requested a review from gmischler as a code owner December 4, 2024 09:47
@K-Hern K-Hern changed the title Resolves #1311 Fixes #1311 Dec 4, 2024
@K-Hern K-Hern changed the title Fixes #1311 Resolves #1311 - <a> HTML tag applying styling rules to all following content Dec 4, 2024
@Lucas-C
Copy link
Member

Lucas-C commented Dec 6, 2024

Thank your for your contribution @K-Hern 👍 🙂

Could you please rebase your branch on this repo master branch?

I fixed the problem that made the GitHub Actions pipeline fail.

…f bitwise operation & result assignment; Prevents original value from persisting - Restoring
@Lucas-C
Copy link
Member

Lucas-C commented Dec 16, 2024

Hi @K-Hern

I performed the branch rebase.

The addition of a new simple unit test covering this case will be required before merging this PR.

Are you stilling willing to continue the work on this?
If so, this can really wait a few weeks, no hurry.

Else I'll take the time to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants