Fix invalid locale error #2766
Merged
Fix invalid locale error #2766
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattHag
force-pushed
the
fix_invalid_locale_error
branch
3 times, most recently
from
2a21c47 to
4e50c7c
Compare
|
What's the failing test mean? |
MattHag
force-pushed
the
fix_invalid_locale_error
branch
from
4e50c7c to
4f6fdd7
Compare
Generalize exception to catch anything locale error. Related pwr-Solaar#2507 Fixes pwr-Solaar#2765
MattHag
force-pushed
the
fix_invalid_locale_error
branch
from
4f6fdd7 to
5115fb3
Compare
|
It still does not patch it properly on Linux, so removed that part of the change. The test need to pass independent of the system locale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2765