Rule storage with AbstractRepository pattern #2678
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattHag
force-pushed
the
rules_persister
branch
from
23b02ab to
3703249
Compare
Introduce a AbstractRepository as interface to the rules database and implement a YML storage that implements it. Additionally, a FakeStorage implements that interface to test diversion related code, without I/O calls and side effects. It keeps the rules in-memory for the test duration. Related pwr-Solaar#2675
Introduce a higher level storage provider interface to decouple storage implementation from diversion dialog and use composition to pass an implementation. This simplifies testing of the diversion dialog and enables clean unit testing without I/O. Related pwr-Solaar#2675
MattHag
force-pushed
the
rules_persister
branch
from
3703249 to
d778382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2675