fix: make comment ranges work #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were there any issues for this? |
|
Only relevant issue is: #303 But there seems to be a lot of refactoring since then. Possible it broke or most people are using keymaps to create multiline comments? I'm not sure. I'd want the command to work for multi-line comments, as I already have far too many keymaps and just typing things out are becoming an easier approach. |
Previous to this comment highlighting several lines and running the command "Octo comment add" would never result in a multi-line comment. This is seemingly because as soon as you enter the command line with ':' Neovim is switched back into normal mode and the "v" and "." attributes to `vim.fn.line` no longer register for the line range. Instead, we can use the explicit start and end marks for a selected range to capture the currently selected range despite being in normal mode at time of command run. Signed-off-by: ldelossa <[email protected]>
ldelossa
force-pushed
the
ldelossa/make-comment-ranges-work
branch
from
559e06e to
f369961
Compare
|
Awesome. Let me take a look tomorrow |
wd60622
approved these changes
Jan 22, 2025
|
Closes #587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this comment highlighting several lines and running the command "Octo comment add" would never result in a multi-line comment.
This is seemingly because as soon as you enter the command line with ':' Neovim is switched back into normal mode and the "v" and "." attributes to
vim.fn.lineno longer register for the line range.Instead, we can use the explicit start and end marks for a selected range to capture the currently selected range despite being in normal mode at time of command run.
It is now possible to highlight several lines in a review and then call "Octo comment add" to create a multi-line comment.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist