Skip to content

Commit

Permalink
bugfix: container build environment variable
Browse files Browse the repository at this point in the history
Container builds have their own environment. So setting an environment variable as part of the workflow does not work unless it is passed into the container build.

At this time it makes more sense to have the environment variable just set during container build (but only during the first building stage)
  • Loading branch information
Peter Van Bouwel committed Nov 28, 2024
1 parent d64e0c2 commit 6ee37f4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/container_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ on:
- v*
env:
IMAGE_NAME: fakes3pp
NO_TESTING_BACKENDS: "GithubAction"

jobs:
# This pushes the image to GitHub Packages.
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ WORKDIR /usr/src/fakes3pp
RUN go mod download
RUN go mod tidy
ADD . /usr/src/fakes3pp/
ENV NO_TESTING_BACKENDS=container_build
RUN go test -coverprofile cover.out ./...
RUN go vet
RUN CGO_ENABLED=0 GOOS=linux go build -o main .
Expand Down

0 comments on commit 6ee37f4

Please sign in to comment.