aivision for beta release #729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 use `pros` instead of `prosv5` in Makefile
* move version information * update scripts and makefiles * add version.h to main.h * fix bugs on windows and linux * move version.h to pros folder * update header comments
Rocky14683
force-pushed
the
pros-4/feature/aivision
branch
from
47d2af4 to
7d24160
Compare
WillXuCodes
requested changes
Dec 17, 2024
| @@ -40,6 +40,7 @@ | |||
| #endif /* __cplusplus */ | |||
|
|
|||
| #include "pros/adi.h" | |||
| #include "pros/aivision.h" | |||
There was a problem hiding this comment.
So I'm not really a big fan of the "aivision" name, at least make it ai_vision or ai_camera (underscore matters the most, vision might be a little to ambigious)?
There was a problem hiding this comment.
(actually vision is fine but I'd prefer a underscore between ai and vision just for readability's sake)
| namespace pros { | ||
| inline namespace v5 { | ||
|
|
||
| enum class AivisionDetectType : uint8_t { color = (1 << 0), code = (1 << 1), object = (1 << 2), tag = (1 << 3) }; |
There was a problem hiding this comment.
be nice to have this on seperate lines for readability's sake:
Suggested change
| enum class AivisionDetectType : uint8_t { color = (1 << 0), code = (1 << 1), object = (1 << 2), tag = (1 << 3) }; | |
| enum class AivisionDetectType : uint8_t { | |
| color = (1 << 0), | |
| code = (1 << 1), | |
| object = (1 << 2), | |
| tag = (1 << 3) | |
| }; |
Comment on lines
+31
to
+33
| claim_port_i(port - 1, E_DEVICE_AIVISION); | ||
| uint8_t enabled_detection_types = vexDeviceAiVisionEnableGet(device->device_info); | ||
| return_port(port - 1, enabled_detection_types); |
There was a problem hiding this comment.
Suggested change
| claim_port_i(port - 1, E_DEVICE_AIVISION); | |
| uint8_t enabled_detection_types = vexDeviceAiVisionEnableGet(device->device_info); | |
| return_port(port - 1, enabled_detection_types); | |
| claim_port_i(port - 1, E_DEVICE_AIVISION); | |
| uint8_t enabled_detection_types = vexDeviceAiVisionEnableGet(device->device_info); | |
| return_port(port - 1, enabled_detection_types); |
Inconsistent spacing
|
|
||
| int32_t aivision_get_class_name(uint8_t port, int32_t id, uint8_t * class_name) { | ||
| claim_port_i(port - 1, E_DEVICE_AIVISION); | ||
| vexDeviceAiVisionClassNameGet(device->device_info, id, class_name); |
There was a problem hiding this comment.
Same thing here, it's a spaces vs tabs issue (we have a formatter on kernel right?)
| return c::aivision_set_code(this->_port, &code); | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ai vision sensor for beta release(so no docs for cpp)