Fixed "make all" failing when IS_LIBRARY:=1 #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works without the change. |
On a fresh project or Kernel? I was able to reproduce this on a fresh project. |
|
oops sorry, My bad. I didn't know it needs to be a fresh project. |
Rocky14683
dismissed stale reviews from WillXuCodes and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Created the "bin" directory at the start when compiling a library
Motivation:
Not sure if this is the right place to modify this but currently, on a fresh project, changing to
IS_LIBRARY:=1in the Makefile and runningpros make allwill fail to compile. The issue is caused by not being able to find the "bin" folder.Test Plan:
IS_LIBRARY:=1in the Makefilepros make allpros make all