New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix some bugs in weird edge cases #242

Merged

AndrewLuGit merged 2 commits into develop from bugfix/weird-bugs

Dec 18, 2024

Contributor

AndrewLuGit commented Dec 14, 2024

Before release, I found some bugs in weird edge cases:

lzma-native does not have a version build for Windows ARM, just like node-usb
Installing pros cli from pip causes semver to freak out because it reports version number as four numbers (ex. 3.5.4.0)

I am fixing these by:

Making lzma-native an optional dependency, just like I did for node-usb. This should be fine, since lzma-native is only used to extract the toolchain xz files on mac and linux, and the windows toolchain is a zip file.
Coercing the pros cli version number so semver is happy

AndrewLuGit added 2 commits

December 13, 2024 23:44


          fix some bugs


          run prettier

fea4421

Rocky14683 approved these changes

View reviewed changes

Member

Rocky14683 left a comment

LGTM

AndrewLuGit merged commit ca6158b into develop

3 checks passed

AndrewLuGit deleted the bugfix/weird-bugs branch

December 18, 2024 16:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet