Address permissions error when committing format changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat root. This solves the permission error more elegantly that setting safe dir or changing the ownership to root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened, since I used the wrong feature branch in the previous PR
I've run permissions trouble when committing the changes made after running the formatter. It turns out that the Docker user defaults to root, so the commit action isn't able to add the changes to the git repo. I've added a USER argument in the Dockerfile to assume UID 1001, GUID 121 (observed when running ls -la .git/objects after running the formatter) which has solved my permissions issue. The alternative is to chown -R the entire git repo, but this seemed more elegant to me. Note that the UID/GUID might be different for other users, so I'll need to look into automating this discovery somehow
I also added a parameter to format against a different base to HEAD^ (e.g. master) - I thought it useful when working with large PRs