Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single element ipset array should be in sync with its string equivalent #1208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2fa
Copy link
Contributor

@2fa 2fa commented Apr 4, 2024

Summary

Currently if you have a single value ipset parameter it will always be trying to correct itself on every puppet run.

Additional info

I tried to create proper acceptance test for this case but it requires installed ipset package with created ipsets for testing so i decided not to do it.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@2fa 2fa requested a review from a team as a code owner April 4, 2024 16:08
@2fa 2fa changed the title Single element ipset array should be in sync with it string equivalent Single element ipset array should be in sync with its string equivalent Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants