Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auth.conf.d resources #1087

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add auth.conf.d resources #1087

wants to merge 8 commits into from

Conversation

aba-rechsteiner
Copy link

No description provided.

@aba-rechsteiner aba-rechsteiner requested a review from a team as a code owner January 27, 2023 11:03
@puppet-community-rangefinder
Copy link

apt::auth is a type

that may have no external impact to Forge modules.

apt is a class

Breaking changes to this file WILL impact these 250 modules (exact match):
Breaking changes to this file MAY impact these 47 modules (near match):

apt::params is a class

that may have no external impact to Forge modules.

This module is declared in 235 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

smortex
smortex requested changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there seems to be some extra bits (see in-line comment).

manifests/init.pp Outdated
Comment on lines 408 to 412
$sources.each |$key, $value| {
apt::source { $key:
* => $value,
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look like a duplicate of the above block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, I removed the block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex requested changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aba-rechsteiner @CLAassistant @smortex @ia-content @wolfaba