Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Fix ruby 3.x incompatibility #1

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

jordanbreen28
Copy link

@jordanbreen28 jordanbreen28 commented Oct 26, 2023

It was noted that this gem was failing spec tests when running on ruby 3.x and above. The root cause of this issue seemed to be the absolute_path property found on the Thread::Backtrace::Location class. Updating this to path allows spec tests to pass on both ruby 2.x and 3.x.

Can confirm that when consumed by other tools, this also works as expected.

It was noted that this gem was failing spec tests when running on ruby 3.x and above.
The root cause of this issue seemed to be the absolute_path property found on the Thread::Backtrace::Location class.
Updating this to path allows spec tests to pass on both ruby 2.x and 3.x.

Can confirm that when consumed by other tools, this also works as expected. Open to suggested changes and improvements.
@jordanbreen28 jordanbreen28 force-pushed the bug-fix_ruby3_incompatibility branch from f3bc76c to 273d4b0 Compare October 26, 2023 15:32
@jordanbreen28 jordanbreen28 force-pushed the bug-fix_ruby3_incompatibility branch from 2237f21 to 303293a Compare October 27, 2023 07:43
The webrick gem is no longer shipped as part of the ruby stdlib as of
3.x.
Add a development requirement to the .gemspec, as we use this gem for
testing.
@GSPatton GSPatton merged commit b9e1470 into main Oct 27, 2023
5 checks passed
@jordanbreen28 jordanbreen28 deleted the bug-fix_ruby3_incompatibility branch October 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants