Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "(CAT-2051): Add 'tooling' folder to be included while packaging 'puppetlabs-kubernetes'" #105

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Oct 7, 2024

Reverts #104

Further discussion with the team revealed this merge is not viable given recent commitments made towards the tool. Reverting this as it was merged under wrong assumptions.

@LukasAud LukasAud added the bugfix label Oct 7, 2024
@LukasAud LukasAud requested a review from a team as a code owner October 7, 2024 11:36
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (8a1b7f1) to head (98b52ab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files           2        2           
  Lines         158      158           
=======================================
  Hits          113      113           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 added maintenance maintenance and removed bugfix labels Oct 7, 2024
@jordanbreen28 jordanbreen28 merged commit 2a5a267 into main Oct 7, 2024
12 checks passed
@jordanbreen28 jordanbreen28 deleted the revert-104-CAT-2051-add-tooling-to-not-ignored-path-while-packaging branch October 7, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants