Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Include missing function, facts.d and example dirs in module builds #102

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

Add missing function, facts.d and example dirs to module builds.

Now fully matches https://github.com/puppetlabs/puppet-specifications/blob/master/language/module.md

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner September 24, 2024 08:01
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1b33adc). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage        ?   71.51%           
=======================================
  Files           ?        2           
  Lines           ?      158           
  Branches        ?        0           
=======================================
  Hits            ?      113           
  Misses          ?       45           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@alex501212 alex501212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanbreen28 jordanbreen28 merged commit 8d95ac9 into main Sep 24, 2024
12 checks passed
@jordanbreen28 jordanbreen28 deleted the bug-add_functions_dir_to_build branch September 24, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants