Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a gem for puppet-editor-services #382

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

genebean
Copy link
Contributor

Summary

This PR adds a gemspec and executables that would be called from it. The three executables are variations of the same files that reside in the root of the repo.

Additional Context

The idea here is to make it easier for people like myself to install a local copy of puppet-editor-services. This will facilitate easier use as a language server in things like neovim. Additionally, my hope is to use this gem as the basis for a Nix package that I would maintain.

I do imagine that some more specific requirements could be added to the runtime dependencies listed in the gemspec - if you have feedback on that, I am happy to adjust.

Checklist

I didn't do the check list because I didn't do any changes to the code, this is just setting up packaging.

@genebean genebean requested a review from a team as a code owner June 11, 2024 21:39
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

@genebean
Copy link
Contributor Author

BTW, I'd be happy to contribute a GitHub Action to build and publish the gem if y'all want.

@jordanbreen28
Copy link
Contributor

@genebean this is great, I'll bring this up with the team and we will get back to you on this!

@david22swan
Copy link
Member

@genebean This looks like a good change to use, if you could fix the Rubocop error showing we could then look into testing this properly.
Just as a note you seem to have pushed the actual gem that you built by accident, this would need to be removed.

Thank you for the work, this is an interesting piece that we feel is a good idea to move forward with.

@genebean
Copy link
Contributor Author

If anything published, it is to where ever this repo's preexisting ci pushed it. I will see if I can see where that is and will also look at the error mentioned.

@genebean
Copy link
Contributor Author

Rubocop error fixed.

As for a published gem, I don't have but one gem on rubygems and it isn't this one. I looked and my fork isn't running CI at all and no release jobs in this repo have my name as the triggerer so I am not sure what you are talking about. I for sure don't want to inadvertently have a gem out there though so please let me know if I missed something.

@genebean
Copy link
Contributor Author

I am guessing you all will see this too, but I was looking at the failing mend test and saw this error:

Warning: missing required secrets: MEND_API_KEY MEND_TOKEN

@genebean
Copy link
Contributor Author

@genebean This looks like a good change to use, if you could fix the Rubocop error showing we could then look into testing this properly. Just as a note you seem to have pushed the actual gem that you built by accident, this would need to be removed.

Thank you for the work, this is an interesting piece that we feel is a good idea to move forward with.

If there is anything you can share about the "proper" testing, that would be useful to know as a contributor.

@LukasAud LukasAud merged commit e00eeee into puppetlabs:main Jul 26, 2024
11 of 12 checks passed
@david22swan david22swan mentioned this pull request Jul 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants