-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a gem for puppet-editor-services #382
Conversation
BTW, I'd be happy to contribute a GitHub Action to build and publish the gem if y'all want. |
@genebean this is great, I'll bring this up with the team and we will get back to you on this! |
@genebean This looks like a good change to use, if you could fix the Rubocop error showing we could then look into testing this properly. Thank you for the work, this is an interesting piece that we feel is a good idea to move forward with. |
If anything published, it is to where ever this repo's preexisting ci pushed it. I will see if I can see where that is and will also look at the error mentioned. |
02caad0
to
ce5a16a
Compare
Rubocop error fixed. As for a published gem, I don't have but one gem on rubygems and it isn't this one. I looked and my fork isn't running CI at all and no release jobs in this repo have my name as the triggerer so I am not sure what you are talking about. I for sure don't want to inadvertently have a gem out there though so please let me know if I missed something. |
I am guessing you all will see this too, but I was looking at the failing mend test and saw this error:
|
If there is anything you can share about the "proper" testing, that would be useful to know as a contributor. |
Summary
This PR adds a gemspec and executables that would be called from it. The three executables are variations of the same files that reside in the root of the repo.
Additional Context
The idea here is to make it easier for people like myself to install a local copy of puppet-editor-services. This will facilitate easier use as a language server in things like neovim. Additionally, my hope is to use this gem as the basis for a Nix package that I would maintain.
I do imagine that some more specific requirements could be added to the runtime dependencies listed in the gemspec - if you have feedback on that, I am happy to adjust.
Checklist
I didn't do the check list because I didn't do any changes to the code, this is just setting up packaging.