(CAT-1493) - Fix missing file resource type parameters #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
CAT-1493-fix_missing_parameters
branch
10 times, most recently
from
9932f34
to
31d7eb8
Compare
Prior to this commit, when using the autocompletion feature of puppet-editor-services, the file resource type would be missing some parameters/properties in the dropdown completion list. It was found that this was due to the way the file resource type was structured in the puppet source code. The type defintion can be found in both /lib/puppet/type and /lib/puppet/type/file/. The way we can work around this is by altering the search glob, and combining the type defintions into one single file. This file is then deleted on completion.
jordanbreen28
force-pushed
the
CAT-1493-fix_missing_parameters
branch
3 times, most recently
from
3a3919f
to
7eb1764
Compare
jordanbreen28
force-pushed
the
CAT-1493-fix_missing_parameters
branch
from
7eb1764
to
1f17944
Compare
david22swan
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, when using the autocompletion feature of puppet-editor-services, the file resource type would be missing some parameters/properties in the dropdown completion list.
It was found that this was due to the way the file resource type was structured in the puppet source code. The type definitions can be found in both /lib/puppet/type and /lib/puppet/type/file/*.rb.
The way we can work around this is by altering the search glob, and combining the type definitions into one single file. This file is then deleted on completion.
Additional Context
Before:
After:
We also manually store the type source and calling source, as this allows users to still avail of the
Go to definitionfeature, which will redirect them tolib/puppet/type/file.rb.Related Issues (if any)
Fixes #349
Checklist