Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-1430) - Drop ruby 2.5 Support & Add Ruby 3.x Support #348

Merged
merged 14 commits into from
Sep 29, 2023
Merged

(CAT-1430) - Drop ruby 2.5 Support & Add Ruby 3.x Support #348

merged 14 commits into from
Sep 29, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Sep 21, 2023 •
edited
Loading

Summary

Drops support for ruby 2.5.

Adds support for ruby 3.x

Bumps the runtime dependency gems for puppet-lint and puppet-strings to latest versions.
puppet-lint development gem bumped to ~> 4.0.

See gemfile:

# There should be NO runtime gem dependencies here.  In production this code will be running using the Ruby
# runtime provided by Puppet.  That means no native extensions and NO BUNDLER.  All runtime dependences should
# be re-vendored and then the load path modified appropriately.
#
# This gemfile only exists to help when developing the language server and running tests

Temporarily vendor gem from https://github.com/jordanbreen28/puppetfile-resolver until glennsarti/puppetfile-resolver#41 is merged/released.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner September 21, 2023 11:40
@jordanbreen28 jordanbreen28 changed the title Cat 1430 bump depdencies (CAT-1430) - bump puppet-lint and puppet-strings dependencies Sep 21, 2023
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 3 times, most recently from 9030608 to dbcfbe3 Compare September 21, 2023 13:45
@jordanbreen28 jordanbreen28 changed the title (CAT-1430) - bump puppet-lint and puppet-strings dependencies (CAT-1430) - Drop ruby 2.5 Support & bump puppet-lint/puppet-strings dependencies Sep 21, 2023
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 6 times, most recently from ced6f0b to 74f5b81 Compare September 25, 2023 11:16
@jordanbreen28 jordanbreen28 marked this pull request as draft September 25, 2023 11:16
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 2 times, most recently from 49df64e to 7302237 Compare September 25, 2023 11:20
@jordanbreen28 jordanbreen28 changed the title (CAT-1430) - Drop ruby 2.5 Support & bump puppet-lint/puppet-strings dependencies (CAT-1430) - Drop ruby 2.5 Support & Add Ruby 3.x Support Sep 25, 2023
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 3 times, most recently from 2864875 to 5dc065e Compare September 25, 2023 13:09
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 2 times, most recently from 680d7c4 to 2c94970 Compare September 27, 2023 08:20
@jordanbreen28 jordanbreen28 marked this pull request as ready for review September 27, 2023 08:34
@jordanbreen28
(MAINT) - TEMP pin to FFI 1.15.2
4515c9d 
This change temporarily pins the ffi 1.15.2 gem and pulls this in to be
used in CI for the editor-services.

This change should be temporarily, to resolve failing CI until this bug
is fixed upstream, and released in the next puppet platform release.
See here puppetlabs/puppet#9112
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 11 times, most recently from 9b9c191 to 7d083b6 Compare September 28, 2023 11:44
GSPatton
GSPatton reviewed Sep 28, 2023
View reviewed changes
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
Rakefile Show resolved Hide resolved
@jordanbreen28 jordanbreen28 force-pushed the CAT-1430-bump_depdencies branch 5 times, most recently from a423975 to ec94932 Compare September 28, 2023 14:14
@pmcmaw pmcmaw merged commit 0448784 into main Sep 29, 2023
11 checks passed
@pmcmaw pmcmaw deleted the CAT-1430-bump_depdencies branch September 29, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSPatton GSPatton GSPatton left review comments

@pmcmaw pmcmaw pmcmaw approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanbreen28 @pmcmaw @GSPatton