Fix rubocop warnings #1326
Merged
Fix rubocop warnings #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavindidrichsen
added
the
maintenance
gavindidrichsen
force-pushed
the
maint_fix_rubocop_warnings
branch
4 times, most recently
from
386f733 to
f42e9b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 133 133
Lines 5666 5666
=======================================
Hits 5015 5015
Misses 651 651 ☔ View full report in Codecov by Sentry. |
gavindidrichsen
force-pushed
the
maint_fix_rubocop_warnings
branch
2 times, most recently
from
ccd35cd to
5f8998c
Compare
RSpec/RepeatedSubjectCall: This rule is triggered when the subject is called multiple times in the same example. It's recommended to assign the result of the subject call to a variable and use that variable instead. This rule is important because it helps to prevent unnecessary computation and potential confusion. In RSpec, the subject is not memoized within an example, meaning that each call to subject will create a new instance of the object under test. This can lead to unexpected behavior if the object's state changes between calls. By assigning the subject to a variable and reusing that variable, you ensure that you're always working with the same object and avoid any potential confusion or bugs. Signed-off-by: Gavin Didrichsen <[email protected]>
This error appears something like ``RSpec/DescribedClass: Use `described_class` instead of `PDK::Util`.``. This rule is triggered when the class under test is referenced directly instead of using `described_class`. Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
maint_fix_rubocop_warnings
branch
from
5f8998c to
7fa0468
Compare
jordanbreen28
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist