Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1713) Add retry to flaky tests #1313

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

david22swan
Copy link
Member

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Feb 1, 2024
@david22swan david22swan requested a review from a team as a code owner February 1, 2024 11:08
@david22swan david22swan force-pushed the CAT-1713/main/retries branch from a3b2574 to 4e37dd1 Compare February 1, 2024 11:29
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (040963a) 88.50% compared to head (cde38d6) 88.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         133      133           
  Lines        5664     5664           
=======================================
  Hits         5013     5013           
  Misses        651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan david22swan force-pushed the CAT-1713/main/retries branch from 4e37dd1 to cde38d6 Compare February 1, 2024 14:15
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanbreen28 jordanbreen28 merged commit 4eb9812 into main Feb 2, 2024
10 checks passed
@jordanbreen28 jordanbreen28 deleted the CAT-1713/main/retries branch February 2, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants