(CAT-1618) - Add code coverage to ci

puppetlabs · Jan 8, 2024 · 7c8ae98 · 7c8ae98
1 parent 933eb26
commit 7c8ae98
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,6 +19,7 @@ jobs:
     uses: "puppetlabs/cat-github-actions/.github/workflows/gem_ci.yml@main"
     secrets: "inherit"
     with:
+      rake_task: 'spec:coverage'
       ruby_version: ${{ matrix.ruby_version }}
 
   acceptance:

diff --git a/package-testing/spec/package/support/serverspec_monkeypatch.rb b/package-testing/spec/package/support/serverspec_monkeypatch.rb
@@ -14,7 +14,7 @@ def run
 option_keys << :cwd
 option_keys << :run_as
 
-Specinfra::Configuration.singleton_class.send(:remove_const, :VALID_OPTIONS_KEYS)
+Specinfra::Configuration.singleton_class.send(:remove_const, :VALID_OPTIONS_KEYS) # rubocop:disable RSpec/RemoveConst
 Specinfra::Configuration.singleton_class.const_set(:VALID_OPTIONS_KEYS, option_keys.freeze)
 RSpec.configuration.add_setting :cwd
 RSpec.configuration.add_setting :run_as

diff --git a/spec/unit/pdk/config/namespace_spec.rb b/spec/unit/pdk/config/namespace_spec.rb
@@ -144,7 +144,7 @@ def spec_simple_validator
       expect([config.fetch(:foo, 'default'), config.fetch('foo', 'default')]).to all(eq('bar'))
     end
 
-    it 'will return the specified default value for unknown values' do
+    it 'returns the specified default value for unknown values' do
       expect([config.fetch(:missing, 'default'), config.fetch('missing', 'default')]).to all(eq('default'))
     end