Add unit tests to aws-python #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
force-pushed
the
justin/tests-aws-python
branch
from
ba78131 to
d616543
Compare
justinvp
commented
Dec 17, 2024
|
|
||
| # Create an AWS resource (S3 Bucket) | ||
| bucket = s3.BucketV2('my-bucket') | ||
| import infra |
There was a problem hiding this comment.
Moves resource creation to a separate module, which is consistent with the change for aws-typescript. See #863 (comment).
This was referenced Dec 17, 2024
justinvp
requested review from
a team,
mjeffryes,
mikhailshilkov and
meagancojocar
julienp
reviewed
Dec 19, 2024
| # Test helper to convert a Pulumi Output to an Awaitable. | ||
| # This should only be used in tests. | ||
| T = TypeVar("T") | ||
| def awaitable(output: pulumi.Output[T]) -> Awaitable[T]: |
There was a problem hiding this comment.
Maybe to_awaitable ? await awaitable(...) reads a bit clumsy, and I find it a bit too close to uppercase Awaitable. I don't feel very strongly about this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
aws-pythontemplate to include unit tests, similar to #863 foraws-typescript.Part of #865