Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some workflow fixes #805

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Some workflow fixes #805

merged 1 commit into from
Jul 3, 2024

Conversation

cnunciato
Copy link
Contributor

@cnunciato cnunciato commented Jul 3, 2024

Makes a few fixes to get these tests updated, simplified, and passing:

  • Bumps all actions to their latest versions
  • Adds a step to install Scala (sbt) on macOS (as it's apparently no longer installed by default on GitHub's runners)
  • Consolidates all three "run the tests" workflows (cron, ci, and run-templates-command) into a single test-templates workflow, since they were all doing pretty much the same thing (i.e., running the tests)
  • Tidies up some naming

Fixes #744.
Fixes #750.
Fixes #764.

@cnunciato cnunciato force-pushed the cnunciato/744 branch 2 times, most recently from d9449dd to e635b4f Compare July 3, 2024 02:36
.github/workflows/cron.yml Outdated Show resolved Hide resolved
@cnunciato cnunciato changed the title Bump setup-java to v4 Some workflow fixes Jul 3, 2024
@cnunciato cnunciato force-pushed the cnunciato/744 branch 8 times, most recently from c45821d to 2640731 Compare July 3, 2024 16:19
@cnunciato cnunciato closed this Jul 3, 2024
@cnunciato cnunciato reopened this Jul 3, 2024
@cnunciato cnunciato force-pushed the cnunciato/744 branch 2 times, most recently from eea796a to 4ed4486 Compare July 3, 2024 16:24
@cnunciato cnunciato marked this pull request as ready for review July 3, 2024 16:25
@cnunciato cnunciato marked this pull request as draft July 3, 2024 16:26
@cnunciato cnunciato force-pushed the cnunciato/744 branch 8 times, most recently from 5828184 to d790fc5 Compare July 3, 2024 18:32
@cnunciato cnunciato requested review from a team July 3, 2024 19:19
@cnunciato cnunciato marked this pull request as ready for review July 3, 2024 19:19
Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice consolidation!

@cnunciato cnunciato merged commit 02bc92a into master Jul 3, 2024
6 checks passed
@cnunciato cnunciato deleted the cnunciato/744 branch July 3, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants