Move TypeScript to devDependencies #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want magic functions to include typescript as a dependency.
tgummerer
approved these changes
May 10, 2024
Frassle
approved these changes
May 10, 2024
This fixes a bug when running on non x64 architecture that prevents installing the binaries jaxxstorm/action-install-gh-release@410ab39
julienp
force-pushed
the
julienp/ts-dev-dep
branch
from
d7fb8d7 to
c93a01c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want magic functions to include typescript as a dependency.
In #774 we added TypeScript as an explicit dependency so that new projects use a recent version of TypeScript by default. However listing it in
dependenciesinstead ofdevDependenciescauses magic functions to bundle it. We avoid this by making it a devDependency.