Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add LangServe AWS template #741

Closed
wants to merge 1 commit into from
Closed

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Feb 1, 2024

This PR adds the LangServe AWS templates

Disclaimer: All other examples, get generated using pulumi convert ... Any changes should be marked in the yaml code

@dirien dirien added this to the 0.100 milestone Feb 1, 2024
@dirien dirien self-assigned this Feb 1, 2024
@dirien dirien force-pushed the dirien/langserve-aws branch from e6409d0 to 3454615 Compare February 1, 2024 20:04
@dirien dirien force-pushed the dirien/langserve-aws branch from 3454615 to 2936c23 Compare February 1, 2024 20:18
@cnunciato cnunciato added size/S Estimated effort to complete (1-2 days). and removed size/S Estimated effort to complete (1-2 days). labels Feb 2, 2024
Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently support two kinds of templates in this repo -- starter templates and architecture templates. Starter templates are super-simple cloud-specific ways to bootstrap new projects, and architecture templates are cloud-specific ways to bootstrap common architectures. This is awesome, but it seems like neither of those; it's more like an example of how to deploy a specific application.

pulumi/examples would therefore be a better place for this, I think. They'd still be templates there (as many examples are), and would still be deployable in the same way (even with Deploy with Pulumi buttons); the only difference would be that you'd call pulumi new https://github.com/pulumi/examples/langserve-aws-ts to invoke them instead. So unless there's a super-strong overriding reason that this needs to go into this repo, I'd suggest we house it there instead.

@scottslowe
Copy link
Contributor

@cnunciato These templates were specifically requested by @aaronkao, although I agree with your sentiment currently that these templates seem to fall somewhere between starter templates and architecture templates. I suppose it could be said that these are architecture templates (to deploy an AI app on LangServe), but I think we'd need to get more focused on the UX for these templates---with the other architecture templates, we had a strong "works out of the box with pulumi up" focus.

@cnunciato
Copy link
Contributor

@dirien Were you still planning on moving this to pulumi/examples?

@dirien
Copy link
Contributor Author

dirien commented Feb 8, 2024

Closing this PR in favour of pulumi/examples repo

@dirien dirien closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants