Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Pinecone serverless index templates #727

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: add Pinecone serverless index templates #727

merged 1 commit into from
Jan 15, 2024

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Jan 13, 2024

Hi,

This PR adds starter templates for the Pinecone provider only for serverless indexes

Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (only one minor change needed on the Python program), but we'll need to include a C# template here as well (or follow up very quickly with a C# template).

pinecone-serverless-python/__main__.py Outdated Show resolved Hide resolved
@dirien
Copy link
Contributor Author

dirien commented Jan 14, 2024

Hi @scottslowe,

thanks for the feedback and review! I must forgot the C# example, but now it is added!

Looking forward for you review.

@dirien dirien merged commit b1f67c6 into master Jan 15, 2024
7 checks passed
@dirien dirien deleted the pinecone branch January 15, 2024 05:55
@cnunciato
Copy link
Contributor

@dirien Can we build a Java template also?

@dirien
Copy link
Contributor Author

dirien commented Jan 15, 2024

@dirien Can we build a Java template also?

@cnunciato we did not generated a Java SDK for the moment!

@cnunciato
Copy link
Contributor

cnunciato commented Jan 15, 2024

How does one use these templates? When I run the TypeScript template with an API key for example, I get this:

Diagnostics:
  pulumi:pulumi:Stack (pinecone-serverless-typescript-03f0d18-dev):
    error: update failed

  pinecone:index:PineconeIndex (my-example-index):
    error: Failed to get Pinecone index: example-index-ts with http error code: 404
    error: failed to get Pinecone index: example-index-ts

Does the template not create the index? Should we prompt for some of these values, then (e.g., index name, AWS region)? Should we revisit the resource, variable, and output naming across all of these templates to be more consistent? And if it's a starter template, shouldn't we instead name it pinecone-$language? (cc @scottslowe)

@cnunciato
Copy link
Contributor

cnunciato commented Jan 15, 2024

Chatted with @dirien and the error may be because my account doesn't have early-access perms for this feature. #729 renames the templates pinecone-$language. We'll add the prompting with defaults in a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants