Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP cloudrun template to use docker image repo digest identifier #695

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

mnlumi
Copy link
Contributor

@mnlumi mnlumi commented Nov 30, 2023

Update GCP cloudrun template to use docker image repo digest identifier

By using image name in the cloud run service, the image won't be redeployed when the app changes currently.

Ref:
pulumi/pulumi-gcp#1166
pulumi/pulumi-docker#726
pulumi/pulumi-docker#739

@mnlumi mnlumi requested a review from cnunciato December 1, 2023 16:28
Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs one fix I think, otherwise 👍.

container-gcp-go/main.go Outdated Show resolved Hide resolved
@cnunciato cnunciato enabled auto-merge (squash) December 8, 2023 23:12
@cnunciato cnunciato merged commit 45ba991 into master Dec 15, 2023
7 checks passed
@cnunciato cnunciato deleted the mnlumi/gcp-docker-image-cloudrun branch December 15, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants