Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-go dependencies #652

Closed
wants to merge 1 commit into from
Closed

Update aws-go dependencies #652

wants to merge 1 commit into from

Conversation

justinvp
Copy link
Member

It looks like the PRs that automatically update Go dependencies haven't been merged in a while.

To make it easier to get started trying the Go generics preview, update the dependencies for the aws-go template to the latest versions, along with the Go 1.20 (one version behind current). That way, users trying out generics, only have to update the pulumi-aws dependency to the preview branch, and don't have to update the core Pulumi SDK to a more recent version.

Subsequently, all the go templates should be updated.

It looks like the PRs that automatically update Go dependencies haven't been merged in a while.

To make it easier to get started trying the Go generics preview, update the dependencies for the aws-go template to the latest versions, along with the Go 1.20 (Go 1.18 and 1.19 are no longer supported). That way, users trying out generics, only have to update the `pulumi-aws` dependency to the preview branch, and don't have to update the core Pulumi SDK to a more recent version.
@justinvp justinvp requested review from cnunciato, scottslowe and a team September 21, 2023 05:54
@Frassle
Copy link
Member

Frassle commented Sep 21, 2023

go: go.mod file indicates go 1.20, but maximum version supported by tidy is 1.18

Looks like CI needs an update as well

@cnunciato cnunciato self-assigned this Sep 21, 2023
@cnunciato cnunciato added this to the 0.94 milestone Sep 21, 2023
@cnunciato
Copy link
Contributor

@justinvp Thanks! And you're right, we were a little behind on these updates. 😓 I went ahead and updated everything in #653, so if that looks okay, maybe we can merge that? Thanks again for the nudge on this.

@justinvp justinvp closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants