Skip to content

Commit

Permalink
always use the latest pulumi dev version in CI (#732)
Browse files Browse the repository at this point in the history
Similar to pulumi/examples#1535, we would like
to use the latest pulumi dev version here instead of just the latest
version.

In face in some places there was some (very outdated and
non-functional) code to attempt that.  Instead of the latest dev
version it downloaded 3.40.0-alpha.1663101047 as of the time of this
writing, which is less than ideal.  Always use the dev version here
unless we explicity request the "latest" version.
  • Loading branch information
tgummerer authored Jan 23, 2024
1 parent e7d1632 commit 1ce14f9
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 21 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ jobs:
go-version: ${{ matrix.go-version }}
- run: go env
- name: Install Pulumi CLI
uses: pulumi/actions@v4
uses: pulumi/actions@v5
with:
pulumi-version: ${{ env.PULUMI_VERSION != '' && format('v{0}', env.PULUMI_VERSION) || null }}
pulumi-version: ${{ env.PULUMI_VERSION != '' && format('v{0}', env.PULUMI_VERSION) || dev }}
- run: pulumi version
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down
15 changes: 3 additions & 12 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,10 @@ jobs:
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go-version }}
- if: matrix.pulumi-version == 'latest'
name: Install Latest Pulumi CLI
uses: pulumi/actions@v4
- if: matrix.pulumi-version == 'dev'
name: Get Latest Dev Version of Pulumi
shell: bash
run: |
echo "DEV_PULUMI_VERSION=$(curl -sSL "http://registry.npmjs.org/-/package/@pulumi/pulumi/dist-tags" | jq -r .dev)" >> $GITHUB_ENV
- if: matrix.pulumi-version == 'dev'
name: Install Latest Pulumi CLI
uses: pulumi/actions@v4
- name: Install Latest Pulumi CLI
uses: pulumi/actions@v5
with:
pulumi-version: ${{ env.DEV_PULUMI_VERSION }}
pulumi-version: ${{ matrix.pulumi-version }}
- run: echo "Currently Pulumi $(pulumi version) is installed"
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/performance_metrics_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,10 @@ jobs:
uses: google-github-actions/setup-gcloud@v0
with:
install_components: gke-gcloud-auth-plugin
# TODO find a way to preferably use latest dev builds here instead:
# https://github.com/pulumi/pulumi/issues/10728
- name: Install Latest Pulumi CLI
uses: pulumi/actions@v4
uses: pulumi/actions@v5
with:
pulumi-version: latest
pulumi-version: dev
- run: echo "Currently Pulumi $(pulumi version) is installed"
- name: Install Testing Dependencies
run: make ensure
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/run-templates-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ env:
LINODE_TOKEN: ${{ secrets.LINODE_TOKEN }}
SKIPPED_TESTS: "alicloud,digitalocean,kubernetes,openstack,equinix-metal,civo,aiven,auth0,github,oci,java-jbang,java-gradle,azuredevops,vm-azure-yaml"
PULUMI_API: https://api.pulumi-staging.io
MIN_PULUMI_VERSION: "3.95.0"
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_CLIENT_SECRET: ${{ secrets.ARM_CLIENT_SECRET }}
ARM_SUBSCRIPTION_ID: ${{ secrets.ARM_SUBSCRIPTION_ID }}
Expand Down Expand Up @@ -76,9 +75,9 @@ jobs:
go-version: ${{ matrix.go-version }}
- run: go env
- name: Install Pulumi CLI
uses: pulumi/actions@v4
uses: pulumi/actions@v5
with:
pulumi-version: ${{ env.MIN_PULUMI_VERSION != '' && format('^v{0}', env.MIN_PULUMI_VERSION) || null }}
pulumi-version: dev
- run: pulumi version
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down

0 comments on commit 1ce14f9

Please sign in to comment.