Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate PF accurate previews feature flag #2808

Merged

Conversation

VenelinMartinov
Copy link
Contributor

We've decided to postpone rolling out PF accurate previews, so the SDKv2 bridge and the PF bridge need separate feature flags. This change adds a new feature flag for PF and keeps the old one for the SDKv2.

related to #2598

@VenelinMartinov VenelinMartinov requested a review from a team January 2, 2025 17:47
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.63%. Comparing base (d9d48ae) to head (f626162).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/pf/tfbridge/provider.go 0.00% 3 Missing and 1 partial ⚠️
pkg/pf/tfbridge/provider_diff.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2808      +/-   ##
==========================================
- Coverage   68.73%   68.63%   -0.11%     
==========================================
  Files         325      325              
  Lines       41536    41536              
==========================================
- Hits        28549    28507      -42     
- Misses      11381    11423      +42     
  Partials     1606     1606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three thoughts:

  1. Should we add a separate env var for this as well?

  2. It's a little unfortunate that EnableAccurateBridgePreview doesn't really convey that it's SDKv2 only, I appreciate the callout on info.go

  3. do we intend to keep any of these feature flags longterm? Is the goal to eventually onboard every provider and then remove these flags? Or will we consolidate them? Leave both?

@VenelinMartinov VenelinMartinov force-pushed the vvm/separate_pf_accurate_previews_feature_flag branch from d0d4e19 to 2654012 Compare January 2, 2025 17:59
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Jan 2, 2025

  1. Yup, good point, I've added one in case we have a use for that.
  2. It is unfortunate but I've opted to keep the public interface backwards compatible instead. I think the slight misnaming should be fine here.
  3. Yup, that's the plan. Onboard all providers and then deprecate the flags. PF is on hold for now.

@VenelinMartinov VenelinMartinov force-pushed the vvm/separate_pf_accurate_previews_feature_flag branch from 2654012 to 1805cd2 Compare January 2, 2025 18:01
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding the env var!

I agree that a breaking change would be entirely too much work here for not enough gain. 👍

@VenelinMartinov VenelinMartinov merged commit 2150faf into master Jan 6, 2025
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/separate_pf_accurate_previews_feature_flag branch January 6, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants