-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a separate PF accurate previews feature flag #2808
Add a separate PF accurate previews feature flag #2808
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2808 +/- ##
==========================================
- Coverage 68.73% 68.63% -0.11%
==========================================
Files 325 325
Lines 41536 41536
==========================================
- Hits 28549 28507 -42
- Misses 11381 11423 +42
Partials 1606 1606 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three thoughts:
-
Should we add a separate env var for this as well?
-
It's a little unfortunate that EnableAccurateBridgePreview doesn't really convey that it's SDKv2 only, I appreciate the callout on info.go
-
do we intend to keep any of these feature flags longterm? Is the goal to eventually onboard every provider and then remove these flags? Or will we consolidate them? Leave both?
d0d4e19
to
2654012
Compare
|
…postpone its rollout
2654012
to
1805cd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding the env var!
I agree that a breaking change would be entirely too much work here for not enough gain. 👍
We've decided to postpone rolling out PF accurate previews, so the SDKv2 bridge and the PF bridge need separate feature flags. This change adds a new feature flag for PF and keeps the old one for the SDKv2.
related to #2598