Fix overeager diffs #1927
Merged
Fix overeager diffs #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1927 +/- ##
==========================================
+ Coverage 60.26% 60.59% +0.33%
==========================================
Files 329 329
Lines 44467 44422 -45
==========================================
+ Hits 26797 26917 +120
+ Misses 16170 15995 -175
- Partials 1500 1510 +10 ☔ View full report in Codecov by Sentry. |
|
LGTM. Are all the AWS issues you linked of the same shape as the test? Is there a meaningfully different schema on any of these resources which we can use for additional testing here? |
|
They are slight variations on the same theme of Wafv2 nested schema. |
VenelinMartinov
added a commit
that referenced
this pull request
May 6, 2024
This reverts commit c57799f, reversing changes made to e71c1a6. reverts #1893 We have some downstream failures: https://github.com/pulumi/pulumi-azure/actions/runs/8945276805/job/24576271881?pr=2001 https://github.com/pulumi/pulumi-github/actions/runs/8945161556/job/24576285007?pr=652 Some opened issues which look like prerequisites: pulumi/pulumi-azure#1421 (related to the failure above) pulumi/pulumi-confluentcloud#264 (we don't have credentials here, so likely why it did not produce a downstream failure) Anton also noted [some issues](#1927) with SkipDetailedDiff in AWS, so this change seems much less risky than initially though.
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With AWS 3880 there is some evidence (derivation in #1917) that sometimes TF has entries in the InstanceDiff.Attributes while still planning to take the resource to the end-state that is identical to the original state. IN these cases, TF does not display a diff but Pulumi does.
The root cause here remains unfixed (#1895) - Pulumi bridge is editing terraform-pulgin-sdk to expose the InstanceDiff structure to connect it to the makeDetailedDiff machinery. Pulumi should, like TF, stick to the gRPC protocol and rely only on the PlannedState value.
We can incrementally approach the desired behavior with this change though which detects PlannedState=PriorState case and suppresses any diffs in this case.
Fixes: