Remove cluster setup from CI #3386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
- Coverage 41.14% 41.08% -0.07%
==========================================
Files 85 87 +2
Lines 12764 12900 +136
==========================================
+ Hits 5252 5300 +48
- Misses 7122 7205 +83
- Partials 390 395 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few goals with ci-mgmt:
One of the special cases to address is p-k's cluster setup, which currently injects special jobs/steps into the normal workflow.
Instead, we can setup (and optionally tear down) the cluster as part of the test suite.
This PR revives some of @rquitales' work in master...rquitales/tune-presubmits. The setup is simplified somewhat to more closely mirror what we do today -- spin up a single KinD cluster on CI, or a GKE cluster on releases.
GKE is handled via API calls instead of as a Pulumi stack, which is (arguably) simpler and lets us initiate cluster deletion without needing to wait for it to be completely gone.
When run locally, we will continue to use existing
~/.kube/config. We will only create a new cluster locally if you happen to run tests without any cluster at all -- for example if you're a new developer.The setup is slightly suboptimal because
TestMainonly applies at a package level, and our nodejs e2e have two packages. We'll also eventually spin up a GKE cluster per test shard, instead of one for the entire run. We can consider ways to optimize this later.The KinD support works great. GKE is still a WIP and the PR's tests are failing while I debug that.
The ci-mgmt changes will be upstreamed.