Apply default dependencies when called from Pulumi CLI

[danielrbradley]

The pulumi package gen-sdk command calls GeneratePackage directly, so we need to apply the defaults at that layer rather than in the pulumi-java-gen specific code.

Fixes #1500

[lunaris]

Looks good -- thanks for raising!

[danielrbradley]

From local testing I can confirm this fixes two of the three missing dependencies in pulumi/pulumi-azure-native#3776

However, the third missing dependency is actually the Pulumi Java SDK itself. This is added when calling the pulumi-java-gen binary directly because the build process bakes in the version number. However, AFAIK there's no way for a Go package to fetch its own version automatically.

Question for @lunaris and @Frassle: do we just hard code the self-reference and manually bump it as required or should we do something clever like letting the pulumi/cmd set the verison?

[Frassle]

do we just hard code the self-reference and manually bump it as required or should we do something clever like letting the pulumi/cmd set the verison?

We add it as a linker flag when building. https://github.com/pulumi/pulumi-java/blob/main/.goreleaser.yml#L22

[danielrbradley]

We add it as a linker flag when building. https://github.com/pulumi/pulumi-java/blob/main/.goreleaser.yml#L22

That's fine when building the binary, but for pulumi package gen-sdk it's running this code as a go module reference, so doesn't get the version injected because there's no "build time". Unless I'm missing something about how we release the go package?

[blampe]

Also unblocks pulumi/pulumi-kubernetes#3151

[Frassle]

That's fine when building the binary, but for pulumi package gen-sdk it's running this code as a go module reference, so doesn't get the version injected because there's no "build time". Unless I'm missing something about how we release the go package?

Oh right yeh. We plan on moving this code to run over grpc so it will actually be in the build pulumi-language-java binary. Probably easier to just wait for that change. I imagine we're close to switching over, I think the java binary does now support these rpc calls.

[danielrbradley]

Ok, will stick with the hard coded default for now but can override that when we do the grpc plugin change.