Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

couple of minor fixes while building docs #4222

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

interurban
Copy link
Collaborator

Description

Checklist:

@interurban interurban requested a review from cnunciato as a code owner April 24, 2024 05:18
@pulumi-bot
Copy link
Collaborator

Your site preview for commit c1b22bd is ready! 🎉

http://pulumi-hugo-origin-pr-4222-c1b22bd4.s3-website.us-west-2.amazonaws.com.

@interurban interurban requested a review from a team April 24, 2024 05:23
@pulumi-bot
Copy link
Collaborator

Your site preview for commit fc32dbe is ready! 🎉

http://pulumi-hugo-origin-pr-4222-fc32dbef.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 7226dfc is ready! 🎉

http://pulumi-hugo-origin-pr-4222-7226dfcd.s3-website.us-west-2.amazonaws.com.


Any Preview of a Refresh is considered a drift detection run in Pulumi Cloud. Running drift detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Any preview of a refresh is considered a drift detection run in Pulumi Cloud. Running Drift Detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is drift detection a proper noun?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Products are proper nouns (Pulumi Deployments), features/capabilities should not be.

* Update or delete a Drift schedule
* Pause or resume a Drift schedule
* Create a drift schedule
* Get a drift schedule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you dont use it as a proper noun. May want to be more consistent

Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone from product should maybe chime in, but to me, these are features of the Pulumi Deployments product, not names of a separate product, so should not be capitalized.


Any Preview of a Refresh is considered a drift detection run in Pulumi Cloud. Running drift detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Any preview of a refresh is considered a drift detection run in Pulumi Cloud. Running Drift Detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Products are proper nouns (Pulumi Deployments), features/capabilities should not be.


## Runing Drift detection from the CLI
## Running Drift Detection from the CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Running Drift Detection from the CLI
## Running drift detection from the CLI


Any Preview of a Refresh is considered a drift detection run in Pulumi Cloud. Running drift detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Any preview of a refresh is considered a drift detection run in Pulumi Cloud. Running Drift Detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Any preview of a refresh is considered a drift detection run in Pulumi Cloud. Running Drift Detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.
Any preview of a refresh is considered a drift detection run in Pulumi Cloud. Running drift detection from the CLI is as simple as running `pulumi refresh --preview-only` or even just `pulumi refresh`, which will first run a preview (thereby creating the drift run), before running the actual refresh.

@@ -66,22 +66,22 @@ You can integrate Drift notifications to Slack, MS Teams, and more using Pulumi

![Drift Webhook Events](../drift-webhook-events.png)

Summary of Drift Events
### Summary of Drift Detection and Remediation events
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Summary of Drift Detection and Remediation events
### Summary of drift detection and remediation events

@meagancojocar
Copy link
Contributor

Someone from product should maybe chime in, but to me, these are features of the Pulumi Deployments product, not names of a separate product, so should not be capitalized.

Let's capitalize for now.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit be21da3 is ready! 🎉

http://pulumi-hugo-origin-pr-4222-be21da3d.s3-website.us-west-2.amazonaws.com.

@interurban interurban merged commit ab45c89 into master Apr 24, 2024
2 checks passed
@interurban interurban deleted the james/4-24-docs-updates branch April 24, 2024 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants