Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

add blog for pulumi up/destroy --continue-on-error #4194

Merged
merged 10 commits into from
May 9, 2024
Merged

add blog for pulumi up/destroy --continue-on-error #4194

merged 10 commits into from
May 9, 2024

Conversation

tgummerer
Copy link
Contributor

Description

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@tgummerer tgummerer force-pushed the tg/continue-on-error-blog branch from 789be9f to dbc6c4d Compare April 22, 2024 12:16
@pulumi-bot
Copy link
Collaborator

Your site preview for commit dbc6c4d is ready! 🎉

http://pulumi-hugo-origin-pr-4194-dbc6c4da.s3-website.us-west-2.amazonaws.com.

@tgummerer tgummerer marked this pull request as ready for review April 22, 2024 14:51
@tgummerer tgummerer requested a review from cnunciato as a code owner April 22, 2024 14:51
@tgummerer tgummerer requested a review from a team April 22, 2024 14:51
@tgummerer
Copy link
Contributor Author

Marking this ready for review to get some feedback, however we definitely need to wait for the next pulumi release before we can release this.

@justinvp justinvp mentioned this pull request Apr 22, 2024
Closed
12 tasks
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 81c84e9 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-81c84e97.s3-website.us-west-2.amazonaws.com.

justinvp
justinvp reviewed May 6, 2024
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

Should we add a concluding remark, like "Give it a try and let us know if you find it useful." Or something else along those lines?

themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
@tgummerer
Copy link
Contributor Author

Should we add a concluding remark, like "Give it a try and let us know if you find it useful." Or something else along those lines?

Yeah, I like that. Added.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit ea479ce is ready! 🎉

http://pulumi-hugo-origin-pr-4194-ea479cee.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3dccb18 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-3dccb185.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 4876374 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-48763742.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit c96a512 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-c96a512c.s3-website.us-west-2.amazonaws.com.

@lukehoban lukehoban self-requested a review May 6, 2024 18:24
justinvp
justinvp approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions, but otherwise looks good to me. I'm happy to takeover merging the suggestions and any other feedback.

Still needs a meta.png image.

themes/default/content/blog/continue-on-error/index.md Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
themes/default/content/blog/continue-on-error/index.md Outdated Show resolved Hide resolved
justinvp
justinvp reviewed May 8, 2024
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on the meta image now. Scratch that. Looks like I don't have access to edit the Figma file anymore.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3bf9216 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-3bf9216a.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit e4b90a1 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-e4b90a12.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit c23eac7 is ready! 🎉

http://pulumi-hugo-origin-pr-4194-c23eac7e.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 6bd10da is ready! 🎉

http://pulumi-hugo-origin-pr-4194-6bd10da4.s3-website.us-west-2.amazonaws.com.

@justinvp justinvp merged commit 429d976 into master May 9, 2024
2 checks passed
@justinvp justinvp deleted the tg/continue-on-error-blog branch May 9, 2024 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinvp justinvp justinvp approved these changes

@lukehoban lukehoban lukehoban approved these changes

@cnunciato cnunciato Awaiting requested review from cnunciato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgummerer @pulumi-bot @lukehoban @justinvp