Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup gcp preconfigure check #1552

Merged
merged 9 commits into from
Jan 27, 2024
Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 24, 2024

similar to pulumi/pulumi-aws#2949

Run preconfigure check only once. This removes duplication of config warnings.

Before:

Diagnostics:
  pulumi:pulumi:Stack (gcp_vm-dev):
    warning: unable to detect a global setting for GCP Project;
    Pulumi will rely on per-resource settings for this operation.
    Set the GCP Project by using:
        `pulumi config set gcp:project <project>`
    warning: unable to detect a global setting for GCP Project;
    Pulumi will rely on per-resource settings for this operation.
    Set the GCP Project by using:
        `pulumi config set gcp:project <project>`
    error: preview failed

After:

Diagnostics:
  pulumi:pulumi:Stack (gcp_vm-dev):
    warning: unable to detect a global setting for GCP Project;
    Pulumi will rely on per-resource settings for this operation.
    Set the GCP Project by using:
    	`pulumi config set gcp:project <project>`

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 26, 2024 15:47
@VenelinMartinov VenelinMartinov merged commit f147fd6 into master Jan 27, 2024
16 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/dedup_gcp_preconfigure_check branch January 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants