Add provider upgrade tests #929
Conversation
| "id": "4b6db602-50de-4739-ac98-93c6c721d82b", | ||
| "type": "pulumi:providers:aws", | ||
| "inputs": { | ||
| "version": "5.31.0" |
There was a problem hiding this comment.
Hmm. This is not right unfortunately. The specification stated 5.42.0 - which should have been the provider that got installed in PATH. Either that's the provider really being used but the version here is taken from the SDK, or the ambient plugin installation didn't work right.
t0yv0
requested review from
danielrbradley,
thomas11 and
a team
and removed request for
danielrbradley
| }) | ||
| } | ||
|
|
||
| func test(t *testing.T, dir string, opts ...providertest.Option) *providertest.ProviderTest { |
There was a problem hiding this comment.
I don't see where t is used.
| func test(t *testing.T, dir string, opts ...providertest.Option) *providertest.ProviderTest { | |
| func test(dir string, opts ...providertest.Option) *providertest.ProviderTest { |
| t.Run("cluster", func(t *testing.T) { | ||
| test(t, "../examples/cluster").Run(t) | ||
| }) |
There was a problem hiding this comment.
I don't see any opportunity for the call to test(...) to fail. We should just be able to elide the func here:
| t.Run("cluster", func(t *testing.T) { | |
| test(t, "../examples/cluster").Run(t) | |
| }) | |
| t.Run("cluster", test(t, "../examples/cluster").Run) |
There was a problem hiding this comment.
Well well, you have to leave markers for the IDE to let you click on the test to run it. I really need to test it in VS Code.
|
I've done some more work on providertest to lean harder into pre-existing ProgramTest features to do TypeScript programs much cleaner but I didn't integrate it back here yet. Tomorrow.. |
|
With providertest 0.0.2 it should be handling TypeScript SDKs correctly. |
Proposed changes
This PR adds upgrade tests that verify that taking a stack provisioned on a baseline version of the provider and upgrading it to the current version creates no replacements.
Fixes #927
Dependent PR: pulumi/providertest#19
Related issues (optional)