Skip to content

Commit

Permalink
chore: remove sdk/nodejs/yarn.lock and restore generate_nodejs target (
Browse files Browse the repository at this point in the history
…#1558)

# remove sdk/nodejs/yarn.lock

The Node SDK for the provider does not typically publish a lock file at
Pulumi, see for example:


https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/package.json

It is intended to be used as a library with many possible configurations
of the host program.

Looks like a yarn.lock may have been committed to pulumi-eks by mistake.
Removing.

# make generate_nodejs

The intent is to have `generate_nodejs` be separate from `build_nodejs`
so that minimal work is done when only
re-generating the files is required.

Looks like for all languages other than Node this is the case, but a bad
Git merge still has the Node target missing.
  • Loading branch information
t0yv0 authored Dec 23, 2024
1 parent ee12ab0 commit ba150d6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3,941 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,5 @@ sdk/java/gradlew
sdk/java/gradlew.bat

.envrc

sdk/nodejs/yarn.lock
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ provider:: bin/${PROVIDER}
.pulumi/bin/pulumi:
curl -fsSL https://get.pulumi.com | sh -s -- --version "$(PULUMI_VERSION)"

build_nodejs:: .pulumi/bin/pulumi schema
generate_nodejs:: .pulumi/bin/pulumi schema
cd provider/cmd/$(CODEGEN) && go run main.go nodejs ../../../sdk/nodejs $(CURDIR) ../$(PROVIDER)/schema.json $(VERSION_GENERIC)

build_nodejs:: generate_nodejs
cd sdk/nodejs && \
yarn install --no-progress && \
yarn run build && \
Expand Down
Loading

0 comments on commit ba150d6

Please sign in to comment.