Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream 5.83.1 #5086

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Upstream 5.83.1 #5086

merged 7 commits into from
Jan 13, 2025

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 10, 2025

Upgrades upstream provider to v5.83.1.

Fixes #5068
Fixes #5045

Release notes for v5.83.0: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.83.0
Release notes for v5.83.1: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.83.1

The new ephemeral resource aws_cognito_identity_openid_token_for_developer_identity is not made available yet (#4831)

Copy link

Does the PR have any schema changes?

Found 1 breaking change:

Types

  • 🟢 "aws:dms/getEndpointKafkaSetting:getEndpointKafkaSetting": required: "saslMechanism" property has changed to Required

New resources:

  • bedrock/agentAgentCollaborator.AgentAgentCollaborator
  • cleanrooms/membership.Membership
  • cloudwatch/logDelivery.LogDelivery
  • cloudwatch/logDeliveryDestination.LogDeliveryDestination
  • cloudwatch/logDeliveryDestinationPolicy.LogDeliveryDestinationPolicy
  • cloudwatch/logDeliverySource.LogDeliverySource
  • cloudwatch/logIndexPolicy.LogIndexPolicy
  • vpclattice/resourceGateway.ResourceGateway

New functions:

  • cloudwatch/getEventBuses.getEventBuses
  • ecs/getClusters.getClusters
  • route53/getRecords.getRecords

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 44.58078% with 271 lines in your changes missing coverage. Please review.

Project coverage is 24.46%. Comparing base (5902a17) to head (9b5530c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sdk/go/aws/cleanrooms/membership.go 50.33% 149 Missing ⚠️
sdk/go/aws/rds/integration.go 0.00% 50 Missing ⚠️
sdk/go/aws/quicksight/user.go 58.49% 44 Missing ⚠️
sdk/go/aws/codebuild/fleet.go 16.66% 15 Missing ⚠️
sdk/go/aws/emr/studio.go 25.00% 6 Missing ⚠️
sdk/go/aws/elasticache/user.go 0.00% 4 Missing ⚠️
sdk/go/aws/rds/cluster.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5086      +/-   ##
==========================================
+ Coverage   24.42%   24.46%   +0.04%     
==========================================
  Files         360      361       +1     
  Lines      143403   144037     +634     
==========================================
+ Hits        35023    35243     +220     
- Misses     108281   108696     +415     
+ Partials       99       98       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 requested review from corymhall and flostadler January 11, 2025 00:17
@t0yv0 t0yv0 marked this pull request as ready for review January 11, 2025 00:17
@@ -6020,4 +6020,19 @@ func setupComputedIDs(prov *tfbridge.ProviderInfo) {
) (resource.ID, error) {
return attr(state, "multiRegionClusterName"), nil
}

computeIDPartsByTfResourceID := map[string][]resource.PropertyKey{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@flostadler flostadler merged commit 235ddc7 into master Jan 13, 2025
26 checks passed
@flostadler flostadler deleted the upstream-5.83.1 branch January 13, 2025 10:02
@flostadler flostadler added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Jan 13, 2025
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.66.3.

@github-actions github-actions bot removed the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants