Upgrade terraform-provider-aws to v5.82.1 #4957

flostadler · 2024-12-20T08:57:33Z

This PR was generated via $ upgrade-provider pulumi/pulumi-aws --kind=provider --target-version=5.82.1.

New resources:

apigateway/domainNameAccessAssociation.DomainNameAccessAssociation
cloudfront/vpcOrigin.VpcOrigin
memorydb/multiRegionCluster.MultiRegionCluster
networkmanager/dxGatewayAttachment.DxGatewayAttachment
rds/clusterSnapshotCopy.ClusterSnapshotCopy

New functions:

servicecatalog/getAppregistryAttributeGroupAssociations.getAppregistryAttributeGroupAssociations

Upgrading terraform-provider-aws from 5.81.0 to 5.82.1.
Fixes Upgrade terraform-provider-aws to v5.82.1 #4953

Fixes #4760

github-actions · 2024-12-20T09:40:57Z

Does the PR have any schema changes?

Found 2 breaking changes:

Types

🟢 "aws:codeconnections/HostVpcConfiguration:HostVpcConfiguration": required: "tlsCertificate" property is no longer Required
🟢 "aws:licensemanager/getReceivedLicenseEntitlement:getReceivedLicenseEntitlement": required: "overage" property has changed to Required

New resources:

apigateway/domainNameAccessAssociation.DomainNameAccessAssociation
cloudfront/vpcOrigin.VpcOrigin
memorydb/multiRegionCluster.MultiRegionCluster
networkmanager/dxGatewayAttachment.DxGatewayAttachment
rds/clusterSnapshotCopy.ClusterSnapshotCopy

New functions:

servicecatalog/getAppregistryAttributeGroupAssociations.getAppregistryAttributeGroupAssociations

Maintainer note: consult the runbook for dealing with any breaking changes.

codecov · 2024-12-20T09:41:51Z

Codecov Report

Attention: Patch coverage is 48.05195% with 40 lines in your changes missing coverage. Please review.

Project coverage is 24.42%. Comparing base (f9da959) to head (4ae03c1).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
sdk/go/aws/rds/cluster.go	0.00%	11 Missing ⚠️
sdk/go/aws/autoscaling/group.go	0.00%	9 Missing ⚠️
sdk/go/aws/resourcegroups/resource.go	52.63%	9 Missing ⚠️
sdk/go/aws/directconnect/gateway.go	25.00%	6 Missing ⚠️
sdk/go/aws/memorydb/cluster.go	54.54%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #4957    +/-   ##
========================================
  Coverage   24.41%   24.42%            
========================================
  Files         360      360            
  Lines      143270   143403   +133     
========================================
+ Hits        34984    35023    +39     
- Misses     108187   108281    +94     
  Partials       99       99

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flostadler · 2024-12-20T09:45:17Z

"aws:elasticache/replicationGroup:ReplicationGroup":
🟡 inputs: "atRestEncryptionEnabled" type changed from "boolean" to "string"
🟡 properties: "atRestEncryptionEnabled" type changed from "boolean" to "string"

That seems bad at a first glance. Checking why that happened

flostadler · 2024-12-20T09:53:41Z

hashicorp/terraform-provider-aws#40514 changed atRestEncryptionEnabled of aws:elasticache/replicationGroup:ReplicationGroup to a nullable bool which we model as a string in the bridge (pulumi/pulumi-terraform-bridge#1514).

The ReplicationGroup is a rather widely used resource and atRestEncryptionEnabled is a setting almost everybody running Redis/Valkey in production would set. This is a rather severe breaking change that we cannot ship in a minor IMO

flostadler · 2024-12-20T12:34:05Z

regress-4457 is failing because a new property was added to autoscaling.Group. That test is executing pulumi import and then editing the code to add the necessary changes. The problem is that our python tests use the latest release version of the SDK and that does not include newly added properties, but pulumi import will include them in the generated code. Chicken/Egg problem...

We should rewrite that test to use nodejs (or yaml?) because they are not susceptible to this issue. Skipping for now, opened issue: #4958

flostadler · 2024-12-20T13:14:25Z

Added override for ReplicationGroup atRestEncryptionEnabled to be a boolean and added a test for it

flostadler · 2024-12-20T14:20:24Z

examples/provider_test.go

@@ -317,3 +324,32 @@ func planEqual(t *testing.T, firstPlan, secondPlan string) bool {

 	return assert.Equal(t, firstPlanData, secondPlanData)
 }
+
+func inPlacePulumiTest(t *testing.T, dir string, opts ...opttest.Option) *pulumitest.PulumiTest {


This allows us now to use an in-process provider for the tests. Which will also give us code coverage :)

This is good but might want to be careful to not use this for production release verification in case there's accidentally some behavioral difference between the prod binary and this form of running the provider.

Yeah, before adopting this for all tests we should add some sort of flag/env variable to fall back to attaching the binary for releases

t0yv0 · 2024-12-20T14:30:13Z

examples/examples_py_test.go

@@ -179,6 +179,7 @@ func TestRegress2534(t *testing.T) {
 }

 func TestRegress4457(t *testing.T) {
+	t.Skipf("TODO[pulumi/pulumi-aws#4957]")


What's happening here?

#4957 (comment)

Ah wait, just noticed I linked the PR and not the issue

corrected the link, thanks for noticing!

t0yv0 · 2024-12-20T15:11:55Z

examples/test-programs/elasticache-replication-group/Pulumi.yaml

+  replicationGroupArn: ${replicationGroup.arn}
+resources:
+  replicationGroup:
+    type: aws:elasticache:ReplicationGroup


t0yv0

Thanks!

t0yv0 · 2024-12-20T15:13:51Z

I think it fixes #4760 too

t0yv0 · 2024-12-20T15:14:41Z

This was in https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.82.0

pulumi-bot · 2024-12-23T11:35:59Z

This PR has been shipped in release v6.66.0.

flostadler added 2 commits December 20, 2024 09:48

make tfgen

ec0b225

make build_sdks

f07d1cb

flostadler added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Dec 20, 2024

flostadler requested review from t0yv0, corymhall and a team December 20, 2024 08:59

flostadler self-assigned this Dec 20, 2024

flostadler mentioned this pull request Dec 20, 2024

Upgrade terraform-provider-aws to v5.82.1 #4953

Closed

flostadler added 3 commits December 20, 2024 14:13

Override ReplicationGroup at_rest_encryption_enabled to be a boolean

42760d0

Regen schema & SDKs

25e4571

Add tests

0e4a05e

flostadler commented Dec 20, 2024

View reviewed changes

t0yv0 reviewed Dec 20, 2024

View reviewed changes

correct github issue link

4ae03c1

t0yv0 reviewed Dec 20, 2024

View reviewed changes

t0yv0 approved these changes Dec 20, 2024

View reviewed changes

flostadler enabled auto-merge (squash) December 20, 2024 15:24

flostadler merged commit 8517f88 into master Dec 20, 2024
26 checks passed

flostadler deleted the upgrade-terraform-provider-aws-to-v5.82.1 branch December 20, 2024 16:43

pulumi-bot mentioned this pull request Dec 23, 2024

SQS RedriveAllowPolicy shows spurious JSON diff #4760

Closed

github-actions bot removed the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade terraform-provider-aws to v5.82.1 #4957

Upgrade terraform-provider-aws to v5.82.1 #4957

flostadler commented Dec 20, 2024 •

edited by t0yv0

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

flostadler commented Dec 20, 2024

flostadler commented Dec 20, 2024

flostadler commented Dec 20, 2024 •

edited

Loading

flostadler commented Dec 20, 2024

flostadler Dec 20, 2024

t0yv0 Dec 20, 2024

flostadler Dec 20, 2024

t0yv0 Dec 20, 2024

flostadler Dec 20, 2024

flostadler Dec 20, 2024

flostadler Dec 20, 2024

t0yv0 Dec 20, 2024

t0yv0 left a comment

t0yv0 commented Dec 20, 2024

t0yv0 commented Dec 20, 2024

pulumi-bot commented Dec 23, 2024

Upgrade terraform-provider-aws to v5.82.1 #4957

Upgrade terraform-provider-aws to v5.82.1 #4957

Conversation

flostadler commented Dec 20, 2024 • edited by t0yv0 Loading

github-actions bot commented Dec 20, 2024 • edited Loading

Does the PR have any schema changes?

Types

New resources:

New functions:

codecov bot commented Dec 20, 2024 • edited Loading

Codecov Report

flostadler commented Dec 20, 2024

flostadler commented Dec 20, 2024

flostadler commented Dec 20, 2024 • edited Loading

flostadler commented Dec 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t0yv0 left a comment

Choose a reason for hiding this comment

t0yv0 commented Dec 20, 2024

t0yv0 commented Dec 20, 2024

pulumi-bot commented Dec 23, 2024

flostadler commented Dec 20, 2024 •

edited by t0yv0

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

flostadler commented Dec 20, 2024 •

edited

Loading