Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CI tests for OIDC authentication (#3074)" #3175

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 22, 2023

This reverts commit 385a96a.

Looks like the github action doesn't quite work and this prevents us from releasing the provider.

https://github.com/pulumi/pulumi-aws/actions/runs/7298824685 - the OIDC test job gets skipped when run from main or a tag and that prevents the release of the provider.

@VenelinMartinov VenelinMartinov requested a review from a team December 22, 2023 11:52
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) December 22, 2023 11:52
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@VenelinMartinov VenelinMartinov merged commit 31412fb into master Dec 22, 2023
18 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/revert_oidc_tests branch December 22, 2023 13:47
thomas11 added a commit that referenced this pull request Dec 22, 2023
thomas11 added a commit that referenced this pull request Dec 27, 2023
Revert "Revert "CI tests for OIDC authentication (#3074)" (#3175)". The
other test jobs have no guarding conditions, so this one shouldn't need
any either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants