Stop embedding bridge-metadata.json #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point bridge-metadata.json is a compile-time only concern as it is not needed at runtime at all. This PR makes the change obvious and stops embedding it. This should help the binary size a bit, possibly to the tune of 30MB (uncompressed): 31M provider/cmd/pulumi-resource-aws/bridge-metadata.json 88K provider/cmd/pulumi-resource-aws/runtime-bridge-metadata.json Only runtime-bridge-metadata.json is currently needed.
|
Ah of course need to fix some tests here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point bridge-metadata.json is a compile-time only concern as it is not needed at runtime at all. This PR makes the change obvious and stops embedding it. This should help the binary size a bit, possibly to the tune of 30MB (uncompressed):
31M provider/cmd/pulumi-resource-aws/bridge-metadata.json
88K provider/cmd/pulumi-resource-aws/runtime-bridge-metadata.json
Only runtime-bridge-metadata.json is currently needed.