Fixes empty tag handling #2944
Merged
Fixes empty tag handling #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
force-pushed
the
t0yv0/fix-empty-tag-handling
branch
from
6d4a839 to
1b96168
Compare
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
The test failures indicate that PF support is still required specially; and that this regressed on handling unknown and secrets in tags. |
iwahbe
reviewed
Nov 6, 2023
t0yv0
force-pushed
the
t0yv0/fix-empty-tag-handling
branch
from
95c4614 to
f789c48
Compare
|
I'm deferring the automation suggestion in #2962 - it's very valuable and borderline critical but this fix has been late in coming and I do not want to block on that work. |
iwahbe
reviewed
Nov 7, 2023
|
@iwahbe PTAL. This is passing again. |
|
Yeah! |
t0yv0
added a commit
that referenced
this pull request
Nov 29, 2023
Fixes #3064 There is an issue with users being unable to add tags to AWS Firehose delivery stream and select other resources. As part of the #2944 mitigation the provider needs to make sure that tags_all attributes, if present, are not Computed because pulumi-aws will set them before passing down to TF code. TestTagsAllNoLongerComputed was supposed to check this. Unfortunately the transformation missed that some resources define SchemaFunc instead of Schema, and so did the test. The test is made stricter here, and the underlying transformation is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2895
Requires a bridge change, currently still pre-release: pulumi/pulumi-terraform-bridge@v3.63.2...1e955db
Due to confusing empty values with missing values at several layers of the stack, working with empty tag values was problematic before this change both in the Pulumi provider and in the upstream provider; this is now fixed by:
This is change is now passing an aggressive random-sampled state transition matrix for various combinations of provider-level and resource-level tags.