Remove unused npm dependencies

[justinvp]

It looks like the resolve and builtin-modules dependencies aren't actually used anywhere, so stop depending on them.

The motivation for this change is that the dependency on resolve causes errors to be logged in logs during plugin discovery, because the package includes tests that have malformed package.json files. If we don't actually need the dependency it'd be nice to remove it so those errors are no longer logged (so users don't ask us about them).

Also remove the builtin-modules dependency while cleaning this up, since it doesn't appear to be used either AFAICT.

Similar to #3238
Reference: pulumi/pulumi#17578

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.42%. Comparing base (5037c71) to head (735e0e8).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4971   +/-   ##
=======================================
  Coverage   24.42%   24.42%           
=======================================
  Files         360      360           
  Lines      143403   143403           
=======================================
  Hits        35023    35023           
  Misses     108281   108281           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t0yv0]

These dependencies are from 2018 it seems reasonable that we stopped actually depending on these.

[justinvp]

What's going on with the failing waf test? Something we need to clean up in a test account?

=== NAME  TestAccWAFRuleGroup_basic
    rule_group_test.go:34: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating WAF Rule Group (tfaccze0ep): operation error WAF: CreateRuleGroup, https response error StatusCode: 400, RequestID: ac6aaf1f-be43-45b9-8044-589560f4e5b7, WAFLimitsExceededException: Operation would result in exceeding resource limits.
        
          with aws_waf_rule_group.test,
          on terraform_plugin_test.tf line 17, in resource "aws_waf_rule_group" "test":
          17: resource "aws_waf_rule_group" "test" {
        
--- FAIL: TestAccWAFRuleGroup_basic (15.67s)

[t0yv0]

Yeah I think so. Having a quick look.

[t0yv0]

=== NAME  TestAccWAFRuleGroup_changeNameForceNew
    rule_group_test.go:75: Step 1/3 error: Error running apply: exit status 1

        Error: creating WAF Rule Group (tfaccyzotq): operation error WAF: CreateRuleGroup, https response error StatusCode: 400, RequestID: fcb7db05-54ed-4ab1-8a3b-cecdb02574fb, WAFLimitsExceededException: Operation would result in exceeding resource limits.

          with aws_waf_rule_group.test,
          on terraform_plugin_test.tf line 17, in resource "aws_waf_rule_group" "test":
          17: resource "aws_waf_rule_group" "test" {

ForceNew may be trying to create two of these. Scrolling back a little I think our intent with this test was to smoke-test upstream post-patching with their own tests, somehow we selected waf instead of the newer wafv2 module for this purpose. Rather than raising our account waf quotas we can disable this test or switch to wafv2.

[t0yv0]

#5001 I'll land that first and rebase this to get it in.

[t0yv0]

Thank you for getting this in!