-
Notifications
You must be signed in to change notification settings - Fork 156
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix panics when unknowns are passed into assumeRole (#2824)
Fixes #2818 This needs to be reviewed together with pulumi/terraform-plugin-framework@415dcb7 pulumi/terraform-plugin-framework fork was introduced for this fix specifically.
- Loading branch information
Showing
7 changed files
with
92 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| name: regress-2818 | ||
| runtime: nodejs | ||
| description: Regress pulumi/pulumi-aws#2818 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright 2016-2023, Pulumi Corporation. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Original repro in https://github.com/pulumi/pulumi-aws/issues/2818 | ||
| // Unfortunately CI cannot currently test aws.organizations.Account due to lack of permissions. | ||
| // The trimmed down repro simply tries to pass an unknown into assumeRole. | ||
| // It only works through preview. | ||
|
|
||
| import * as pulumi from '@pulumi/pulumi' | ||
| import * as aws from '@pulumi/aws' | ||
|
|
||
| // Dummy bucket to generate unknowns. | ||
| const b = new aws.s3.Bucket('bucket', {}); | ||
|
|
||
| // Pass an unknown into assumeRole.roleArn. | ||
| const provider = new aws.Provider("provider", { | ||
| assumeRole: {roleArn: b.id.apply(_ => "TODO")}, | ||
| }); | ||
|
|
||
| // If the bug is active, this fails because `pulumi preview` panics when trying to create the provider. | ||
| new aws.s3.Bucket('bucket2', {}, { provider }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "name": "regress-2818", | ||
| "version": "0.0.1", | ||
| "license": "Apache-2.0", | ||
| "scripts": { | ||
| "build": "tsc" | ||
| }, | ||
| "dependencies": { | ||
| "@pulumi/pulumi": "^3.0.0", | ||
| "@pulumi/aws": "^6.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/aws-sdk": "^2.7.0", | ||
| "@types/node": "^8.0.0" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "strict": true, | ||
| "outDir": "bin", | ||
| "target": "es2016", | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "sourceMap": true, | ||
| "experimentalDecorators": true, | ||
| "pretty": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "noImplicitReturns": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "files": [ | ||
| "index.ts" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters