Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade go version to 1.20 #62

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 25, 2024

We have inadvertently picked up go 1.21, when the bridge still needs 1.20

The dependency came from go-snaps, so I've downgraded that to the latest version which doesn't need 1.21

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (8c45fd2) 33.45% compared to head (77cea43) 36.80%.
Report is 4 commits behind head on main.

Files Patch % Lines
providers/providerMock.go 49.05% 53 Missing and 1 partial ⚠️
replay/replay.go 67.56% 20 Missing and 4 partials ⚠️
pulumitest/assertrefresh/asserts.go 66.66% 2 Missing and 1 partial ⚠️
pulumitest/pulumiTest.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   33.45%   36.80%   +3.35%     
==========================================
  Files          42       42              
  Lines        2571     2630      +59     
==========================================
+ Hits          860      968     +108     
+ Misses       1606     1559      -47     
+ Partials      105      103       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov merged commit 0e4bc02 into main Jan 25, 2024
4 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/downgrade_go_version branch January 25, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants