Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/test for local and PRs #57

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Add build/test for local and PRs #57

merged 9 commits into from
Jan 19, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Jan 18, 2024

Introduce more rigorous test approach.

  • Deduplicate some initialization logic.
  • Remove need to have actual cloud credentials to run the tests.
  • Narrow the scope of each test to make its purpose clear.
  • Fix regression in fixing up state names in PreviewProviderUpgrade.

This now covers pretty much all of the positive features we expect to work. Next phase will be adding comprehensive tests for failure cases.

@danielrbradley danielrbradley self-assigned this Jan 18, 2024
- Make all tests parallel.
- Extract pulumiTestInit method so we're not copying the same code into 3 places.
- Extract testContext method to create context with deadline if required.
- Make tests properly parallel by marking within sub-tests.
Add very simple, targeted test cases to match specific features.
Copy link

codecov bot commented Jan 18, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@danielrbradley danielrbradley requested review from t0yv0 and a team January 18, 2024 20:45
@danielrbradley danielrbradley merged commit 510510c into main Jan 19, 2024
4 checks passed
@danielrbradley danielrbradley deleted the meta-test branch January 19, 2024 07:40
@mjeffryes mjeffryes added this to the 0.99 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants