Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum pulumi requirement #119

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Bump minimum pulumi requirement #119

merged 3 commits into from
Dec 27, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 27, 2024

pulumi/pulumi#17898 was a breaking change for projects that directly depend on pulumi/sdk but not pulumi/pkg, which is the case with several native providers.

If these projects upgrade to [email protected] or later, they can still indirectly depend on earlier versions of pkg via libraries like this one. This leads to errors like the following:

go: github.com/pulumi/pulumi-command/provider/pkg/provider tested by
	github.com/pulumi/pulumi-command/provider/pkg/provider.test imports
	github.com/pulumi/providertest imports
	github.com/pulumi/pulumi/pkg/v3/testing/integration imports
	github.com/pulumi/pulumi/sdk/v3/go/common/tools: cannot find module providing package github.com/pulumi/pulumi/sdk/v3/go/common/tools

This bumps our minimum required version of pkg to one which accounts for pulumi/pulumi#17898.

This problem is self-inflicted and only exists because we choose to version sdk and pkg separately despite there being a tight coupling between the two. We would not have this problem if we released them together as a single module with sdk and pkg packages.

@blampe blampe requested review from t0yv0 and a team December 27, 2024 22:16
@blampe blampe merged commit 1c99244 into main Dec 27, 2024
2 checks passed
@blampe blampe deleted the blampe/pu-bump branch December 27, 2024 22:39
@pulumi-bot
Copy link

This PR has been shipped in release v0.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants